"Jeroen De Dauw" posted a comment on MediaWiki.r111264. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30899
Commit summary for MediaWiki.r111264: adding DBDataObject class after having some people review it and posting on the list. docs can currently be found at https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject Jeroen De Dauw's comment: > The use of static variables to store database connection objects There is one static field readDb, which is clearly documented as storing an integer (element of DB_ enum), not a database connection object. > heavy use of static variables generally Like I said, there is one such field, and it's not part of the core functionality (so how does this count as heavy use?), so can be killed, or probably better, be replaced by an additional optional argument for all methods that read from the db. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
