"Aaron Schulz" posted a comment on MediaWiki.r111342. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111342#c30910
Commit summary for MediaWiki.r111342: Give a warning when people use $wgArticle. Add's a class that can be used to give warnings for other globals too. See discussion on r111168. Of course no one will see warning because trunk has $wgDeprecationReleaseLimit set to 1.17 by default (<rant>have I mentioned how I don't like that variable. People enable warnings to be *warned* about things. Making it so people won't get warned about things until a couple months after we've decided people should stop using function/interface/etc defeats the purpose of having warnings</rant>) p.s. Wasn't sure if this waranted something in the release notes, I don't think it does (It's just adding a warning) but wasn't sure. Aaron Schulz's comment: <code>wfDeprecated( '$' . $this->mGlobal, $this->mVersion, false, 6 );</code> These needs a code comment to explain the 6. Interesting that there *is* a comment to explain the 'm' prefixes. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
