"Trevor Parscal" changed the status of MediaWiki.r109808 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109808#c30954
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109808: Fix Bug 33875. Control+ minus key giving keycode of 'm' Trevor Parscal's comment: This is very confusing to read because you are mixing concepts here, char codes and key codes. * Char codes are mappable ASCII and only come through on keypress events. * Key codes are partially mappable (pretty much only lowercase english letters) to ASCII and come through on keydown and keyup events. People get them confused a lot. When I trace the execution back, the function fired from a keydown handler, so these are key codes. You should use a number and comment what you mean by the number. Converting a key code to a string using String.fromCharCode( e.which ) is insane. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
