"Hashar" posted a comment on MediaWiki.r111391.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111391#c30981

Commit summary for MediaWiki.r111391:

Clearing out entries that give "Not a valid host or IP address on line"

Hashar's comment:

 # *.cache.pol.co.uk
 -webcacheh01a.cache.pol.co.uk.
 -webcacheh02a.cache.pol.co.uk.
 +webcacheh01a.cache.pol.co.uk
 +webcacheh02a.cache.pol.co.uk

You should keep the trailing dot. When running generate, those entry are passed 
to gethostbynamel() which attempt a DNS resolution. Without the . , each DNS 
entry will have a search suffix appended and another DNS query will be made 
(see /etc/resolv.conf ).

:-)


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to