"Catrope" changed the status of MediaWiki.r111378 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111378#c31010
Old Status: ok
> New Status: fixme
Commit summary for MediaWiki.r111378:
[RL] Comment mod and other minor changes
_ Add comment about why it casts to (object)
- Modify function comment
- Whitespace (start the function body on a new line in debug mode. In
production mode this is trimmed away afterwards)
- Remove the jQuery->$ passage from loader. There is already a global alias for
$ by jQuery, and aside from that every module has it's own (function(){})
wrapper that aliases it from jQuery (not from $), so there is no performance
gain either by having it locally here since it doesn't use that.
Catrope's comment:
Please don't break the automagic $ aliasing in the closure. I agree that in
theory it shouldn't be needed (and obviously it doesn't work in debug mode),
but in practice hiding errors in production is nice.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
