"Jarry1250" posted a comment on MediaWiki.r111186. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111186#c31089
Commit summary for MediaWiki.r111186: Fixes Bug 18704 - Add an unique CSS class or ID to the tagfilter table row at RecentChanges Patch from Jarry1250 Jarry1250's comment: Okay, got the problem. My patch had the line: <pre> + $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ), ), + Xml::input( 'tagfilter', 20, $selected, array( 'class' => 'tagfilter-input' ) ) ); </pre> Which has a stray comma (no idea how it got there). Thankfully Mark noticed this and removed it; however, in doing so, he has managed to shift one of the brackets from the first line to the second. The correct lines should be: <pre> + $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ) ), + Xml::input( 'tagfilter', 20, $selected, array( 'class' => 'tagfilter-input' ) ) ); </pre> That is to say, the top line shouldn't have changed at all, only the second line. Thanks! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
