"Awjrichards" posted a comment on MediaWiki.r111746.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111746#c31109

Commit summary for MediaWiki.r111746:

Fix for PHP Fatal error:  Call to protected method WebRequest::getRawIP() from 
MobileFrontend.body.php on line 723

Awjrichards's comment:

Actually wfGetIP() won't get us what we want here - it'll give us the client's 
IP address rather than the proxy's (in the event that there is a proxy). 
Somehow I neglected to notice the fact that getRawIP was protected. Now just 
pulling the IP from $_SERVER['REMOTE_ADDR'] which should give us the most 
recently used proxy or the client's ip if no proxies were used in r111777.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to