"Aaron Schulz" changed the status of MediaWiki.r111588 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31126
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r111588:
important fix inside HttpFunctions.php. I noticed that when you call
HttpRequest::factory with noProxy=true for example inside an intranet, this is
ignored in (Curl)HttpRequest because the proxy url is not cleared. This commit
makes sure at lowest level - namel in the public function proxySetup() - that a
optional(true) value of noProxy is observed and that it (now) also clears the
proxy url. (I have been told that I am allowed to commit this patch. Please
carefully review, as usual).
Aaron Schulz's comment:
<pre>+ if ( $this->proxy && !$this->noProxy ) {</pre>
Shouldn't this be an OR statement?
This code goes about this awkwardly. Instead of having to remember to check
noProxy all the time, just nuke the proxy var in the constructor and where
wgHTTPProxy is checked.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
