"Awjrichards" posted a comment on MediaWiki.r111465.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111465#c31147

Commit summary for MediaWiki.r111465:

Reduce global (ab)use

Various code updates

Trim trailing whitespace

Awjrichards's comment:

<code>
function trySubmit() {
72              -               global $wgOut,$wgUser;
        74      +               global $wgOut;
</code>
Why did you leave $wgOut here?

This otherwise looks ok to me.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to