"Awjrichards" posted a comment on MediaWiki.r111350.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31174
Commit summary for MediaWiki.r111350:
fix for bug30377 : add a new parameter to limit the number of characters when
rendering the channel item <description>
Awjrichards's comment:
Ah indeed - I missed the comment line and didn't know we had those functions
overloaded in GlobalFunctions.php.
As for the indentation, I think convention dictates that the case() statements
should be indented an additional level from switch().
And as for even using the switch() statement this way, I think it's just a
matter of style - personally I find this much more confusing when reading
through code quickly than using if() {} elseif().
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
