"Hashar" changed the status of MediaWiki.r111829 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111829#c31214
Old Status: new New Status: fixme Commit summary for MediaWiki.r111829: Add support to tablesorter to handle IP/CIDR notation This fixes bug 34475 Hashar's comment: /36 is not a valid IPv4 mask since an IP address is 32 bits. Instead of randomly generated IP, you need to make a list that would actually stress the code. For example making sure 100.0.0.0 is after 10.0.0.0. Or 10.0.0.1 after 10.0.0.0 but before 10.0.0.2. How would you sort 10.0.0.0/24 vs 10.0.0.0/16. And 10.0.0.0/24 vs 10.0.0.0 ? I guess an IP should be normalized to use a /32 mask then sort using that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
