"Hashar" posted a comment on MediaWiki.r111829. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111829#c31222
Commit summary for MediaWiki.r111829: Add support to tablesorter to handle IP/CIDR notation This fixes bug 34475 Hashar's comment: It is not reason to make false assumptions and write tests based on random content. We need obvious test cases and make sure the code does respect them. The code will sort a single IP by appending 000. Thus we could well have a sort output like: 10.0.0.0 10.0.0.0/0 10.0.0.0/32 which does not make sense since the first (10.0.0.0) is strictly the same as 10.0.0.0/32. If we add CIDR notation support, we might as well have the sorter properly use it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
