"Dantman" changed the status of MediaWiki.r111439 to "reverted" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111439#c31279
Old Status: new New Status: reverted Commit summary for MediaWiki.r111439: Introduce property: and itemprop: support for addMeta to add RDFa <meta property="..." content="..."> and Microdata <meta itemprop="..." content="..."> to the <head>. This is done in a way that can also be feature tested, and technically could be expanded by extensions. Dantman's comment: I'm not going to bother getting this reviewed till after the git migration, so for now it's reverted anyways (thankfully I feature tested so extensions won't break anyways). A few notes though: * I'm not opposed to the idea of a separate defined api in OutputPage for defining the page-wide Microdata of a page in an intuitive way. * However I see no value in having extensions outputting Microdata in-body and using itemref to point to properties in the <head>. ** Microdata items have absolutely no connection to the non-microdata contents of the document. Whether the data was inserted inside the head, or inside the body doesn't affect the Microdata at all. So if an extension outputs any itemscope into the body then there is absolutely no value in putting the itemprops inside the <head> instead of putting them inside the itemscope in the body. ** The only value at all in putting an itemprop inside the head is as a place to add a few of the general properties to the one global itemscope, namely WebPage, like itemprop="name". * If we do opt instead for an api to add page-wide Microdata to a page, we should probably do the same for RDFa instead of this addMeta method. ** It would also be good for said RDFa API to embed xmlns/prefix handling as well, instead of having extensions modify $wgXhtmlNamespaces. ** We should probably also take into account that the spec defining RDFa+HTML5 seams to say that for RDFa purposes an xmlns:*= is valid in HTML5 and tweak our code to not omit namespaces when $wgHtml5 is true. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
