"Aaron Schulz" posted a comment on MediaWiki.r112036.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112036#c31318

Commit summary for MediaWiki.r112036:

Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()

Aaron Schulz's comment:

<pre>
3486    # @todo FIXME: What about the File we have already moved?
3487    $dbw->rollback();
</pre>

Does rollback not need __METHOD__? That seems wrong.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to