"Nikerabbit" changed the status of MediaWiki.r112215 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31416
Old Status: deferred New Status: fixme Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Nikerabbit's comment: parseInt should have second parameter to always use base 10. Not fan of the custom html attributes, but likely not a problem. galleryId is unused. v_vertical and v_rtl leak into global scope. I'd pull $( this ) into variable instead of calling it over and over again. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
