"Nikerabbit" posted a comment on MediaWiki.r112300.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112300#c31439
Commit summary for MediaWiki.r112300:
Fixes for r94907/r94908: change in fallback behaviour allowing infinite loops.
Tested SecurePoll and LandingCheck, not DonationInterface.
Nikerabbit's comment:
And how would you test that?
You can still cause infinite loop by doing:
<pre>
$code = 'pt';
while ( $code !== 'en' ) {
$code = Language::getFallbackFor( $code );
}
</pre>
Which is also the reason getFallbackFor is deprecated. I don't think there is
any non-hacky way to make that code not to go into infinite loop.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
