"Jeroen De Dauw" posted a comment on MediaWiki.r112215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112215#c31442
Commit summary for MediaWiki.r112215: bug 34411 patch by MWJames, somewhat modified Jeroen De Dauw's comment: Stuff not remarked upon below taken care off in follow up. > Not fan of the custom html attributes, but likely not a problem. What do you suggest doing instead? > v_vertical and v_rtl leak into global scope Huh??? They are in a closure... How are they getting into global scope, and how would you fix this? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
