"Kaldari" changed the status of MediaWiki.r109666 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109666#c31455
Old Status: new New Status: fixme Commit summary for MediaWiki.r109666: added checkoutResult() for generating more informative user-facing errors Kaldari's comment: It looks like you're implementing a getter and a setter in the same function in checkoutResult(), which is confusing. I would split these into two functions, e.g. setCheckout( $checkoutInfo ) and getLastCheckout(). Also, minor style issue: you're missing spaces in the following lines at the end: + $this->assertEquals( $firstId, $res['userId'], "User matches on success"); + $this->assertTrue( array_key_exists( 'expiration', $res ), "Expiration is present"); + $this->assertEquals( $firstId, $res['userId'], "Actual owner matches on failure"); _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
