"SPQRobin" changed the status of MediaWiki.r112479 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31504

Old Status: fixme
New Status: new

Commit summary for MediaWiki.r112479:

Combine getLanguageNames and getTranslatedLanguageNames into one function which 
is much easier and more logical to use. Does not contain any actual changes yet 
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that 
gave "invalid code" when selecting

SPQRobin's comment:

When fetchLanguageNames is not found, it takes LanguageNames::getNames, i.e. 
CLDR directly, so it doesn't need to use getTranslatedLanguageNames. (It's even 
better this way, because the mentioned problem was present when calling 
getTranslatedLanguageNames.)

Confirmed that it works using a 1.18 checkout with trunk Translate.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to