"Catrope" changed the status of MediaWiki.r111211 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111211#c31546
Old Status: new New Status: fixme Commit summary for MediaWiki.r111211: bug 34090 - Added a log namespace and log types for the Article Feedback v5 extension to create a log of all activity that takes place to feedback including abuse flagging, hiding and unhiding, and other actions. This is not entirely finished, there are two known cases (decline oversight and auto-hide) that are not yet being logged properly and because the extension doesn't have notes/reasons for activity in place yet there is placeholder text instead. For now activity can be viewed on the special:logs page. The api hooks are not yet complete for the feedback page. Catrope's comment: <pre> + $page = Title::newFromID( $pageId ); + $title = $page->getPartialURL(); </pre> You're using $page for the Title object, and then $title for something that is not a Title object, and then $title for something that is a Title object? That's a bit confusing. Also, unless the page ID has been validated before this point, Title::newFromID() might return null if fed a nonexistent page ID, which would cause the line below to explode with a fatal error. Marking fixme for the fatal error issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
