"Krinkle" posted a comment on MediaWiki.r112561.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112561#c31549

Commit summary for MediaWiki.r112561:

[IRC Log Message] Fix for protect/protect and protect/modify

* protect/protect and protect/modify were still failing because the output on 
IRC is not matching the i18n messages. The bots look for 
comment.match(<i18n-message> + (optionally) followed by ": user comment").
* The problem with protect/protect and protect/modify is that the protection 
settings are also inserted in somewhere in the message. Before MediaWiki 1.19 
these were included in the IRC message as part of $1 (title). That may be ugly, 
but that's how it has always been. Since the point is to reproduce the old 
output we need to fix this one as well. This will make the output like:

  Krinkle * protected "[[Sandbox [edit=autoconfirmed)]]"

which is exactly how it has been before and that's the the bots rely on (which 
was presumably done originally like that since it was the only way to make the 
output match the i18n message)

* Fixes more bug 34508

Krinkle's comment:

Confirmed live and updated in http://etherpad.wikimedia.org/IRCBot-Messages ; 
protect/protect and protect/modify are working again

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to