"Krinkle" posted a comment on MediaWiki.r111378.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111378#c31567
Commit summary for MediaWiki.r111378:
[RL] Comment mod and other minor changes
_ Add comment about why it casts to (object)
- Modify function comment
- Whitespace (start the function body on a new line in debug mode. In
production mode this is trimmed away afterwards)
- Remove the jQuery->$ passage from loader. There is already a global alias for
$ by jQuery, and aside from that every module has it's own (function(){})
wrapper that aliases it from jQuery (not from $), so there is no performance
gain either by having it locally here since it doesn't use that.
Krinkle's comment:
To get back at this one, I prefer having a script fail in both production and
debug so it be noticed and fixed (it's a very simple fix), instead of having it
silently drag on in production mode but fail in debug mode. Especially since
it's unlikely that a wiki re-setting $ to something else will not notice any
breakage at all. Sooner or later something will break.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
