"Catrope" posted a comment on MediaWiki.r112599. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112599#c31574
Commit summary for MediaWiki.r112599: bug 34090 - follow up to r111211 - rename things to make them "less confusing" - only they're still confusing - comment copiously, return if the pageid is bogus Catrope's comment: Using <code>!$title</code> is fine here, it's done all over core. newFromID() returns null or an ''object'', not a string, so this is totally fine. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
