"Catrope" changed the status of MediaWiki.r111471 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111471#c31581
Old Status: new New Status: fixme Commit summary for MediaWiki.r111471: AFTv5: intermittent commit for developers sync-up Catrope's comment: <pre> + <h3 id="articlefeedbackv5-noteflyover-caption">' + mw.msg( 'articlefeedbackv5-noteflyover-hide-caption' ) + '</h3>\ </pre> This way of including a message is not HTML-safe. This seems to have been changed in a later revision though. <pre> + container.find( '#articlefeedbackv5-noteflyover-caption' ).html( mw.msg( 'articlefeedbackv5-noteflyover-' + action + '-caption' ) ); </pre> This is also not HTML-safe, you should use .text() to insert messages unless you really mean them to be interpreted as HTML. OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
