"Reedy" posted a comment on MediaWiki.r112374. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112374#c31648
Commit summary for MediaWiki.r112374: Attempting to address bug 34653; It seems ApiQueryLogEvents has not kept up with changes to the Logging classes. I've changed some aspects of the ApiQueryLogEvents to use a DatabaseLogEntry object when extracting log row information and updated addLogParams to use this new scheme for handling parameters. I have not been able to sufficiently test this and I am still concerned about backwards compatibility with old parameter formats for older log records as well as parameter handling for the 'rights' and 'block' log types. Reedy's comment: <pre> I have not been able to sufficiently test this and I am still concerned about backwards compatibility with old parameter formats for older log records as well as parameter handling for the 'rights' and 'block' log types. </pre> Yup, you're right. This fixes it for new log entries, but then breaks it for older entries... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
