"Reedy" posted a comment on MediaWiki.r112700.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112700#c31654
Commit summary for MediaWiki.r112700:
Followup r112374/bug 34653
We still get legacy log entries, so grab the data from parameters as applicable
Should probably be encapsulated into DatabaseLogEntry itself, with a
getParamValue esk wrapper
This fixes issues noticed on live site for the moment
TODO: Check if rights/block are still ok (probably not?)
TODO: If (especially if above needs doing) encapsulate grabbing of old/new
parameters to logging code
Reedy's comment:
Rights:
<pre>
<item logid="596568" pageid="80772" ns="2" title="User:Krenair"
type="rights" action="rights" user="Reedy" timestamp="2012-02-20T20:41:05Z"
comment="Active user on irc">
<rights new="sysop" old="" />
</item>
</pre>
<pre>
<item logid="605629" pageid="0" ns="2" title="User:Reedy Bot"
type="rights" action="rights" user="Reedy" timestamp="2012-02-29T18:52:37Z"
comment="">
<rights new="" old="sysop" />
</item>
<item logid="605627" pageid="0" ns="2" title="User:Reedy Bot"
type="rights" action="rights" user="Reedy" timestamp="2012-02-29T18:52:02Z"
comment="">
<rights new="sysop" old="" />
</item>
</pre>
To me, it would look like both Block and rights are fine... So this strikes the
first TODO. And the 2nd becomes slightly less important
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
