"Nikerabbit" posted a comment on MediaWiki.r111217.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111217#c31658

Commit summary for MediaWiki.r111217:

AbuseFilter: Resolve bugs 18374, 28633.
* Store the revision ID associated with a log entry if the action is successful.
* Expose this as a diff link in the UI.
* Implicitly hide log entries if their corresponding revisions are also hidden.
* Includes scope for expanding to log entries if desired.

Nikerabbit's comment:

Instead of 
 Linker::link( ..., wfMessage( ... )->parse(), ... ) 
we usually use ->escaped() here.

Does not exactly follow coding style conventions WRT to whitespace and braces.

Looks sane, but I don't deeply understand the functionality so I haven't tested.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to