"Trevor Parscal" changed the status of MediaWiki.r112750 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112750#c31669
Old Status: new New Status: ok Commit summary for MediaWiki.r112750: [mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it was in REL1_18 * After the 1.19wmf1 deployment several people have complained about various aspects of the new diff styling -- The contrast being too low in the highlighted part (darker background behind bolded text) -- The colors not being obvious perhaps (orange/blue) -- Color blind users not seeing the difference very well between the light tones of the orange and blue -- Trevor mentioned something about W3C Accessibility guidelines To play it safe for now I think we should revert these changes to the status quo, and take the next few days (or weeks) to carefully check the concerns, perhaps look at other diff tools out there for inspiration (GitHub, Gerrit, LocalWiki, ..). * Goes back to r91762 (last rev before REL1_18) -- reverting: r94429, r94461, r101147, r105280, r106884, r107127, r108975, r109932 * Re-opens bug 33335 Trevor Parscal's comment: A new patch that follows W3C Accessiblity guidelines will follow (authored by Timo and I) The reasons these changes need to be reverted are because of violations of guidelines. 1. Don't rely on color along 2. Contrast ratio between background and foreground colors on the changed text portion of a diff is not high enough See: http://www.w3.org/TR/WCAG10/ _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
