"Khorn (WMF)" posted a comment on Wikimedia.r1392. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1392#c31688
Commit summary for Wikimedia.r1392: This should resolve the last issue on r1212. _civicrm_recurring_globalcollect_update_record() was broken up into smaller parts, which will make it easier to see what is going on with prepping the fields to be updated. Khorn (WMF)'s comment: I really hate to say this, but it looks like this commit is moving away from solving what I understood to be the problem. I interpreted that last comment on r1212 to mean "please completely drop the dynamic query construction in favor of static (parameterized) queries, for easier review (both functionality and security)". _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
