"Catrope" changed the status of MediaWiki.r111474 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111474#c31699
Old Status: new New Status: fixme Commit summary for MediaWiki.r111474: bug 34090 - remove a todo - take the note from the flag submission and save it properly, use the feedback length configuration item to chop it if a length is set, 0 means no check Catrope's comment: <pre> + $notes = substr($notes, 0, $wgArticleFeedbackv5MaxCommentLength); </pre> Don't use substr to truncate text, use <code>$wgLang->truncate()</code>. That will truncate things in a safe and sane way for non-ASCII languages. OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
