"Catrope" changed the status of MediaWiki.r111559 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111559#c31702
Old Status: new
New Status: ok
Commit summary for MediaWiki.r111559:
AFTv5: activity feature - intermittent commit, for developers sync-up
Catrope's comment:
<pre>
+ <h3>Activity log</h3>\
+ <a>HELP</a>\
+ <a>CLOSE</a>\
</pre>
Can't tell if this was hardcoded English or if they were just placeholders, but
they're gone in trunk now.
<pre>
+ for( var index in actions ) {
</pre>
Do not use a for .. in loop on an array, ever, it tends to cause problems. This
has been restructured in trunk so it's not in there anymore, but just to warn
you: seriously do not do this.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
