"Aaron Schulz" changed the status of MediaWiki.r111085 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111085#c31714
Old Status: new New Status: ok Commit summary for MediaWiki.r111085: (bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist. Now titles are fixed or deleted, if unfixable, upon loading Special:EditWatchlist. Aaron Schulz's comment: Overall, this is OK. I don't like the object state changes in checkTitle(), it should take an argument by reference that builds the list rather than mutating some weird member variable. >From bawolf's comments, this still needs some work to finish the job, but the >commit is a working improvement. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
