[MediaWiki-CodeReview] [MediaWiki r112856]: New comment added

Thu, 01 Mar 2012 16:19:14 -0800 

"Krinkle" posted a comment on MediaWiki.r112856.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112856#c31725

Commit summary for MediaWiki.r112856:

[CategoryTree] Fix "bad json errors on options= {":" that are populating 
wmf error logs
* Only occurred on category trees produced by <categorytree>. The category 
trees dynamically created when expanding the [+] toggle in the subcategory list 
on a category page were not affected (since those don't have data-ct-options 
attributes and thus JS uses the default via mw.config.get( 
'wgCategoryTreePageCategoryOptions' ), which wasn't double escaped)
* escapeTagsOnly escapes & to &quot;
* Xml::openElement does normal attribute escaping, assuming unescaped input

Before:

<div class=" CategoryTreeTag" data-ct-mode="0" 
data-ct-options="{&amp;quot;mode&amp;quot;:0,&amp;quot;hideprefix&amp;quot;:20,&amp;quot;showcount&amp;quot;:false,&amp;quot;namespaces&amp;quot;:false}">

<div class="CategoryTreeTag" data-ct-mode="0" 
data-ct-options="{&quot;mode&quot;:0,&quot;hideprefix&quot;:20,&quot;showcount&quot;:false,&quot;namespaces&quot;:false}">

Krinkle's comment:

"Before: ... *After:* ..."

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to