"Pgehres (WMF)" posted a comment on Wikimedia.r1400.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1400#c31759

Commit summary for Wikimedia.r1400:

Added _civicrm_recurring_globalcollect_update_record_success() to address 
issues with r1392.

Pgehres (WMF)'s comment:

I know I wasn't really involved in the requirements spec for this module, but 
why are we canceling after two failures?  

Also, not going to lie, the fact that we are canceling contributions in a 
function named _civicrm_recurring_globalcollect_update_record_success seems 
confusing to me.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to