"Krinkle" posted a comment on MediaWiki.r111727.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111727#c31795

Commit summary for MediaWiki.r111727:

Port the convertGrammar method of bs and he to js
Add qunit test cases for the same

Krinkle's comment:

<pre>
 mw.language.grammartest({
        language: 'en',
-       word: 'pen',
-       grammarForm: 'genitive',
-       expected: 'pen\'s',
-       description: 'Grammar test for English'
+       test: [ 
+               { word: 'pen', grammarForm: 'genitive', expected: 'pen\'s', 
description: 'Grammar test for English' }
+       ]
});
</pre>

These lines (especially in later commits) tend to get very long, perhaps just 
put each property on its own line. Looks fine otherwise

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to