"Nikerabbit" posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31816
Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Most of the code around MediaWiki is GPLv2. The license is of course our choice. For example __DIR__ only exists in PHP 5.3.0 onwards. Reading global variables before they are set opens doors to register globals vulnerability. See for example [[Register_globals#Configure_extensions_only_after_their_setup_file_is_included]] Your commenting style is awfully verbose. I cannot figure any reason why comment saying "end of file" is useful. One more thing. PHP does not need semicolon after if/foreach/while blocks, so the convention is to not use them there. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
