"Khorn (WMF)" changed the status of Wikimedia.r1399 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1399#c31834
Old Status: new New Status: ok Commit summary for Wikimedia.r1399: The response should only be marked as a failure if there was no RESULT key found in $this->responseParsed. We are only verifying that we could communicate with the gateway, not whether the payment was denied or accepted. This should now be fixed to reflect our goal. Khorn (WMF)'s comment: It looks like you're only calling it to determine what curlTransaction() returns with, so: Yes. Also, this function is verified to be new to the standalone adapter. <br>Minor style note: I have a vague preference for failing closed in checks like this, but that's hardly a blocking issue. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
