"Krinkle" changed the status of MediaWiki.r113117 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113117#c31835
Old Status: new New Status: fixme Commit summary for MediaWiki.r113117: follow up to r113115, rem not needed args Krinkle's comment: Please don't remove the 'name' and 'id' attributes. The name attribute is vital to the submission of the form (and the value of it should not be assumed but specified in this script where it is used), same for the ID. This isn't a regression compared to how it was before r113115, but while at it, might as well keep it. I'm going to remove the default values for name/id in the Html::namespaceSelector in a moment. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
