"Catrope" changed the status of MediaWiki.r111962 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111962#c31858
Old Status: new
New Status: ok
Commit summary for MediaWiki.r111962:
AFTv5: complete overhaul of special page JS, no more spaghetti code,
restructures around the actions object - this is phase 1, more work to be done
here
Catrope's comment:
<pre>
+ container.find( '#articlefeedbackv5-noteflyover-caption' ).html( mw.msg(
'articlefeedbackv5-noteflyover-' + action + '-caption' ) );
</pre>
This is not an HTML-safe way of including messages, but the vast majority of
these occurrences have been fixed since.
<pre>
+ $l.tipsy( 'show' );
+ $.articleFeedbackv5special.currentPanelHostId = $l.attr( 'id' );
+ return true;
+ // load activity if it is an activity log
+ if( -1 != $l.attr( 'id' ).indexOf( 'articleFeedbackv5-activity-link-' ) ) {
+ $.articleFeedbackv5special.loadActivityLog( $l.closest(
'.articleFeedbackv5-feedback' ).attr( 'rel' ) );
+ }
</pre>
Dead code after return true; , has been removed since.
<pre>
+ console.log('disabled');
</pre>
Debugging code, has been removed since.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
