"Catrope" posted a comment on MediaWiki.r112038. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112038#c31864
Commit summary for MediaWiki.r112038: bug 34090 - added additional counts for filters including unhidden, undeleted (unoversighted) and oversight declined, stored a flag for "has a comment" in the main feedback table to avoid a join or extra query for comment status when doing filtering and count updating, moved the truncation of logging into the logging utility method, rewrote most of the flagging api, simplifying the filtering utility method, moved all of the hiding count adjustements into a single helper method, added auto hide/unhide to requesting oversight (threshold is always one request), and added auto hide (but NOT unhide) to oversight functionality - so oversight will autohide, unoversight will NOT autounhide, altered the filter count update script to rollup/adjust for the new filter values, added the new filters to the feedback page, made sure all flagging activity and feedback saving activity is done inside a single transaction so counts are not updated if changes are not made to the feedback table (and vice versa - no successful count updates, no feedback changes) - this should help to keep the counts in sync with the data in the table Catrope's comment: It does, but it also includes other repopulation things that I don't want to run on the cluster. That comment was a reminder to myself that I need to include those things when I write an alter.sql redux for this deployment. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
