"Awjrichards" changed the status of Wikimedia.r1400 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1400#c31877
Old Status: new New Status: fixme Commit summary for Wikimedia.r1400: Added _civicrm_recurring_globalcollect_update_record_success() to address issues with r1392. Awjrichards's comment: I am inclined to agree with Peter's last point. Unless I'm reading this wrong, it looks like this function cancels a payment. You might consider a more clear function name. Also, the comment states: <pre> + * There are two different queries in this function. + * - payments need to be marked as failure + * - payments need to be marked as cancelled if there have been two prior failures for this EFFORTID (`processor_id`) </pre> But I only see the latter query present in the function. As for Peter's first point, I don't see anything directly related to when a payment gets cancelled, but perhaps the failure threshold for cancellation could be made configurable. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
