"Catrope" changed the status of MediaWiki.r113052 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113052#c31897
Old Status: new New Status: ok Commit summary for MediaWiki.r113052: bug 34090 - remaining backend feature in requirements, oversight email generation with job Catrope's comment: <pre> + // make a title out of our user (sigh) + $user_page = Title::makeTitle( NS_USER, $wgUser->getName() ); </pre> There's a <code>$wgUser->getUserPage()</code> method for this. It also cannot fail, because of the nature of makeTitle() and because User objects with invalid names cannot exist. <pre> + 'page_name' => $title_object->getText(), </pre> This should be ->getPrefixedText() so it includes the namespace prefix. All those Title accessors are kind of confusing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
