"Catrope" changed the status of MediaWiki.r113104 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113104#c31898
Old Status: new New Status: fixme Commit summary for MediaWiki.r113104: bug 34090 - follow up to rr111472 part 3 - totally redo the continue functionality with lots more code Catrope's comment: <pre> + 'ORDER BY' => 'log_timestamp DESC, log_id ASC' </pre> You cannot mix DESC and ASC sorting, that will definitely be slow. In my CR of r111472 I recommended that you drop timestamp sorting and sort only by IS. <pre> + $where[] = '(log_id = ' . $id . ' AND log_timestamp = ' . $ts . ') OR log_timestamp < ' . $ts; </pre> This looks wrong. It should be <code>(log_id = $id AND log_timestamp <= $ts) OR log_timestamp < $ts</code> (<= versus =). OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
