"Krinkle" posted a comment on MediaWiki.r113214.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113214#c31935
Commit summary for MediaWiki.r113214:
[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows
* Fixes:
-- (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on
Windows
Krinkle's comment:
Hm.. it's something I picked up from diving into jQuery. It is weird but i'm
not sure it's awful. Some people prefer it to be written as a tree. So instead
of
<pre>
util.tooltipAccessKeyPrefix = (
// Chrome on Mac
profile.platform === 'mac' ? 'ctrl-option-' :
// Chrome on Windows
// (both alt- and alt-shift work, but alt-f triggers
Chrome wrench menu
// which alt-shift-f does not)
profile.platform === 'win' ? 'alt-shift-' :
// Chrome on Ubuntu (and other?)
'alt-'
);
</pre>
it would be:
<pre>
util.tooltipAccessKeyPrefix = (
profile.platform === 'mac'
// Chrome on Mac
? 'ctrl-option-'
: profile.platform === 'win'
// Chrome on Windows
// (both alt- and alt-shift work, but
alt-f triggers Chrome wrench menu
// which alt-shift-f does not)
? 'alt-shift-'
// Chrome on other (Ubuntu?)
: 'alt-'
);
</pre>
Is that better?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
