"Wikinaut" posted a comment on MediaWiki.r113297.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113297#c31955

Commit summary for MediaWiki.r113297:

fix for bug34763 'RSS feed items (HTML) are not rendered as HTML but 
htmlescaped'; tolerated controlled regression bug30377 'feed item length 
limitation', because this now becomes very tricky when we allow some tags in 
order to close bug 34763.

Wikinaut's comment:

ad i) iframe: I saw in a E:RSS rendered feed 
http://rss.slashdot.org/Slashdot/slashdot one or several iframe tags which came 
through htmlescaped. I will make a deeper analysis of this specific case of 
iframes. I just wanted to be sure that iframes are expressly escaped, however 
we can further discuss this depending on my analysis.

ad ii) this was also discussed with Brion, and not working in the first test: 
not working without a (local sandbox) parsing in the local context as described 
here https://www.mediawiki.org/wiki/Manual:Special_pages#workaround_.231 from 
where it is verbatim copied. Your comment means that the text on 
https://www.mediawiki.org/wiki/Manual:Special_pages#workaround_.231 should be 
further corrected (Brion already corrected 
https://www.mediawiki.org/w/index.php?title=Manual%3ASpecial_pages&diff=505706&oldid=490966
 "fix for calling private func; use the public one").

Summary:
I will checked and make further analysis of the two points you had. However, 
the current code is working as intended, can perhaps be improved. I invite 
everyone - especially parser experts - to help me here, because it was a long 
and windy road already.

Does this sufficiently answer your questions ?


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to