"Elizabeth M Smith" posted a comment on MediaWiki.r113311.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113311#c31981
Commit summary for MediaWiki.r113311:
bug 34090 - fixing the username bugs - apparently using the data- stuff with
jquery makes .data() not work right, so went back to own custom attributes and
pushing them into the javascript method when populating the name/timestamp
Elizabeth M Smith's comment:
data-foo works - kind of
If the attribute is present in the html it is properly added to data and I can
get it out and change it as expected (that was pretty cool)
however, when I then tried to add data('user-hide') to elements that did not
have it present at html load time, I could not
Not sure if this is "spec" or if it's a jquery bug (seriously think it's a
jquery bug)
If I added the attr with an empty value into the html at load time, it worked
fine... But there are four possible data attributes per feedback row so that
would mean putting 4 empty data-blah attributes on every row displayed so I
could change the users/timestamps as necessary - the overhead in that is insane
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
