"Khorn (WMF)" changed the status of Wikimedia.r1455 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455#c32033
Old Status: new New Status: fixme Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. Khorn (WMF)'s comment: We talked about this in IRC, so I'm putting it here for posterity: <pre> (12:01:02 PM) K4-713: You can rekey the array before or after you invoke the hook. (12:01:18 PM) K4-713: There is already a precedent for rekeying before the call. (12:01:27 PM) K4-713: On line 361 of [queue2civicrm.module]. (12:02:15 PM) K4-713: It's not necessarily nice, but it should be consistent, and as your module is newer and hooks are made of chicken bones and voodoo, yours is the safer call to change. </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
