"IAlex" posted a comment on MediaWiki.r113518. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113518#c32113
Commit summary for MediaWiki.r113518: No need to create a new Revision object if we already have one available IAlex's comment: <code>Article::$mRevision</code> is only set in <code>Article::getOldIDFromRequest()</code> and <code>Article::fetchContent()</code>, but the latter will call the former before executing the relevant part of code, so <code>Article::getOldIDFromRequest()</code> cannot be called with a <code>Revision</code> object being set. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview