"IAlex" posted a comment on MediaWiki.r113394.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113394#c32119

Commit summary for MediaWiki.r113394:

* (bug 35014) Fix for r100529: including a special page no longer sets the 
page's title to the included page

IAlex's comment:

Yes it is correct, sorry to not have been more explicit. The problem was that 
<code>OutputPage::addWikiText()</code> uses <code>$wgParser</code> for the 
parse operation and thus the <code>ParserOutput</code> is used for the both the 
parse of the article and the message. The title is set when calling 
<code>OutputPage::addWikiText()</code> inside the special page and get set in 
the <code>ParserOutput</code> used for the parse of the article which in turns 
will be used for the title of the display. <code>Message::parseAsBlock()</code> 
uses the <code>Parser</code> set in <code>MessageCache</code> and the conflict 
won't happen.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to