"Wikinaut" posted a comment on MediaWiki.r113772.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113772#c32138

Commit summary for MediaWiki.r113772:

follow up r113554 . fixing a regression which was introduced in r113554. Making 
now all all ids unique even when you have several polls on a mw page. using, 
new, the resourceloader to load common methods. just a little bit ... more of 
jquery. fixing a forgotten wgParser to parser variable problem. introducing and 
moving js and css to resources.

Wikinaut's comment:

+ 'poll_title' => $parser->mTitle->getText() 
"... getText() gives the human readable version of title without namespace," 
Good point ! Luckily, this is only _written_ into the databases and never used 
when identifying polls and votes: for this, only the hash (md5( text content 
between <poll>...</poll> tags is used). I could simply remove this statement, 
or replace it by namespace:pagetitle .

thanks.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to